-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Missing DeepLinks #12820
Handle Missing DeepLinks #12820
Conversation
ca1838f
to
bf91a8a
Compare
6cd6ac0
to
92e96a6
Compare
6310bdd
to
8d6f792
Compare
5d0d081
to
5277e65
Compare
Looks good, but can't tell if the app I'd in the manifest causes brander issues, hence cc @tobiasKaminsky |
d7d6cd6
to
eb71f54
Compare
eb71f54
to
6f50f0c
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
6f50f0c
to
7c7b91c
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12820.apk |
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12820-Screenshot-blue-Light-07-07 |
What this PR does?
It adds auto verify for intent filters
Adds missing intent filters
Calls handleOpenFileViaIntent() function in line 564 for missing case
Note: If we support only Android 12+ we can delete path patterns and http scheme
How to Test
Note: Works for Only Android 11 and Below
adb shell am start
-W -a android.intent.action.VIEW
-d "YOUR_INTERNAL_SHARE_LINK"\
Why It's Not Working For Android 12+
In Android 12 and beyond, it's not possible to provide generic host data, and you must add an assetlinks.json file to the .well-known directory of every potential host so we can't do that.
How It's Working For Android 12+
Useful links
Our previous topic
Official Documentation
Similar Documentation