-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic Per App Languages #12875
Add automatic Per App Languages #12875
Conversation
7ad624a
to
1cf6d41
Compare
d2bf441
to
e83f168
Compare
@AndyScherzinger It's normal for https://github.com/nextcloud/android/actions/runs/8678863344/job/23816001660?pr=12875 to fail all the time ? |
@Arthur-GYT yes, there is a single screenshot test that needs fixing. I think @alperozturk96 is looking into that one. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
12e55ae
to
185709a
Compare
With latest master screenshot tests should work. |
I have updated the branch |
Signed-off-by: Arthur-GYT <[email protected]>
Signed-off-by: Arthur-GYT <[email protected]>
142660d
to
a10ca3b
Compare
Unfortunately, our ss tests are not stable, sometimes need to re-run again to get successful output. We can try a couple of more time if it's still same, I guess we can force merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested successfully 👍
All is in the title ^^.
https://developer.android.com/guide/topics/resources/app-languages