Show snackbar above FAB

[Unpublished]

Fixes #2475 by placing snackbar above FAB according to Material Design Guidelines:

Snackbars should appear above FABs.

• Tests written, or not not needed

[alperozturk96]

I tested on master. It's already above the FAB.

al.mp4

[Unpublished]

Hey Alper, above isn't meant as overlay but rather vertically above the FAB. See the failing Screenshot test above. (I'll update the screens today)

[alperozturk96]

Hey Alper, above isn't meant as overlay but rather vertically above the FAB. See the failing Screenshot test above. (I'll update the screens today)

Oh okay, I saw it in guidelines. Nevertheless, your PR still same as master.

[Unpublished]

Oh okay, I saw it in guidelines. Nevertheless, your PR still same as master.

As you can see in the updated screenshot tests it isn't...if you can give STR I can have a look.

The video you uploaded is a custom snackbar you added yourself I guess.
How do you call the snackbar?

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	71	71
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	67	67
Correctness	72	72
Dodgy code	345	345
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	6	6
Performance	57	57
Security	19	19
Total	576	576

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12877.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[alperozturk96]

Oh okay, I saw it in guidelines. Nevertheless, your PR still same as master.

As you can see in the updated screenshot tests it isn't...if you can give STR I can have a look.

The video you uploaded is a custom snackbar you added yourself I guess. How do you call the snackbar?

Nope it's not custom, it's a function we use everywhere in the project. I used DisplayUtils.showSnackMessage in FileDisplayActivity's onCreate, seems like the changes you made didn't fix for all FABs but worked for fragments.

The change you made in screenShotTest.yml caused the screenshot tests to complete successfully, and this was a problem we had been facing for a long time. Thank you for that 🎉

Edit:

We have 6 different showSnackMessage functions. I tried to add setAnchorView for other ones and try to call from same activity didn't work but since its better than before, we can merge it.

[Unpublished]

As you can see in the updated screenshot tests it isn't...if you can give STR I can have a look.
The video you uploaded is a custom snackbar you added yourself I guess. How do you call the snackbar?

Nope it's not custom, it's a function we use everywhere in the project. I used DisplayUtils.showSnackMessage in FileDisplayActivity's onCreate, seems like the changes you made didn't fix for all FABs but worked for fragments.
Edit:

We have 6 different showSnackMessage functions. I tried to add setAnchorView for other ones and try to call from same activity didn't work but since its better than before, we can merge it.

I tried calling showSnackMessage in onStart and it worked, I guess in onCreate the view is inflated but not visible yet.

The change you made in screenShotTest.yml caused the screenshot tests to complete successfully, and this was a problem we had been facing for a long time. Thank you for that 🎉

Great! I came across that https://github.com/reactivecircus/android-emulator-runner?tab=readme-ov-file#running-hardware-accelerated-emulators-on-linux-runners recommends using ubuntu in Actions a few weeks ago and just gave it a try 👍

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!