Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Recommended Files #14178

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Feature - Recommended Files #14178

wants to merge 30 commits into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Dec 13, 2024 •
edited
Loading

  • Tests written, or not not needed
Image 1 Image 2

@alperozturk96 alperozturk96 marked this pull request as draft December 13, 2024 14:48
@alperozturk96 alperozturk96 linked an issue Dec 13, 2024 that may be closed by this pull request
Recommended files #14167
Open
@alperozturk96 alperozturk96 mentioned this pull request Dec 13, 2024
Open
@alperozturk96 alperozturk96 force-pushed the feature/recommended-files branch from 3a04088 to b4c1e07 Compare December 16, 2024 11:40
@alperozturk96 alperozturk96 marked this pull request as ready for review December 16, 2024 14:51
@alperozturk96 alperozturk96 force-pushed the feature/recommended-files branch from 5cd9186 to c27f0cd Compare December 16, 2024 14:51
@alperozturk96 alperozturk96 marked this pull request as draft December 16, 2024 14:51
@alperozturk96 alperozturk96 force-pushed the feature/recommended-files branch 2 times, most recently from e1f3b9f to 631b1c2 Compare December 18, 2024 09:44
@alperozturk96 alperozturk96 marked this pull request as ready for review December 18, 2024 10:42
@alperozturk96 alperozturk96 force-pushed the feature/recommended-files branch 3 times, most recently from cb797f6 to 3c2afcd Compare December 20, 2024 08:43
@alperozturk96 alperozturk96 force-pushed the feature/recommended-files branch from 3c2afcd to 4922b0f Compare January 7, 2025 09:29
@tobiasKaminsky
Copy link
Member

2025-01-07-125932

Just tested it with user1 on tos.ltd server.

  • overlapping
  • placeholder shadow?
  • date wrong?

@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Jan 7, 2025 •
edited
Loading

2025-01-07-125932

Just tested it with user1 on tos.ltd server.

  • overlapping
  • placeholder shadow?
  • date wrong?

Didn't come across any UI issues like that before. What's the device model and Android version?

The timestamp returned from the server is in seconds, but our converter function requires it in milliseconds. That’s why I multiplied it by 1000. If the value coming from the server is inconsistent, the date will be incorrect.

We are using the same account for testing, and it appears to be correct on my end.

Screenshot 2025-01-07 at 16 36 39

@alperozturk96 alperozturk96 force-pushed the feature/recommended-files branch 2 times, most recently from a5884ed to ab3244c Compare January 8, 2025 07:51
@alperozturk96
Copy link
Collaborator Author

Screenshot_20250108_085801

@alperozturk96 alperozturk96 force-pushed the feature/recommended-files branch from 35074f4 to 9889f24 Compare January 8, 2025 11:22
@tobiasKaminsky
Copy link
Member

Tested and works now ✔

@alperozturk96 alperozturk96 force-pushed the feature/recommended-files branch from 9889f24 to 48af6f9 Compare January 16, 2025 11:42
alperozturk96 and others added 25 commits January 17, 2025 14:12
@alperozturk96
add dimens
c64541a 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
set on click listener
c08d44d 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
use library, remove mock data
6b51eb9 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
notifyItemChanged
e6aad18 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
notifyItemChanged
d02f61d 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
visual fixes
6822dd5 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
visual fixes
94eee00 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix code analytics
4681ef5 
Signed-off-by: alperozturk <[email protected]>
@tobiasKaminsky @alperozturk96
update lib
82ce90f 
Signed-off-by: tobiasKaminsky <[email protected]>
@alperozturk96
use api
27c2055 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix ui
984bce7 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix ui
292d953 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix ui
7f17549 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix ui
80a3659 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix ss test
b697167 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
shouldShowRecommendedFiles
36c43d2 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix code analytics
17f4828 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
change layout width
7785402 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
update lib
3c50d72 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix duplicated item
daf5860 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
add more padding
b1fd72d 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
better alignment, cleanup list_header
a055086 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
change loader image view background color
248d83c 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
rebase
06f4c95 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
update lib
b043995 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the feature/recommended-files branch from aefe1d8 to b043995 Compare January 17, 2025 13:12
@github-actions GitHub Actions
Copy link

test-Unit test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14178.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5555
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total504504

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14178-Screenshot-blue-Light-13-29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
3. to review design enhancement 🍀 2025-Spring
Projects
🤖 🍏 Clients team
Status: 🏗️ In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recommended files
3 participants
@alperozturk96 @tobiasKaminsky @AndyScherzinger