Stopping of docker containers when ExApp is disabling. Backport. (#435)

Added stopping of docker containers when ExApp is disabling. Timeout of enable/disable increased to 60. Manual backport of #430 Signed-off-by: Alexander Piskun <[email protected]>
nextcloud · Oct 31, 2024 · 2d2da9b · 2d2da9b
1 parent e3cb3b6
commit 2d2da9b
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/lib/Service/AppAPIService.php b/lib/Service/AppAPIService.php
@@ -43,6 +43,7 @@ public function __construct(
 		private readonly DockerActions           $dockerActions,
 		private readonly ManualActions           $manualActions,
 		private readonly AppAPICommonService     $commonService,
+		private readonly DaemonConfigService	 $daemonConfigService,
 	) {
 		$this->client = $clientService->newClient();
 	}
@@ -556,7 +557,13 @@ public function getExAppDomain(ExApp $exApp): string {
 	 */
 	public function enableExApp(ExApp $exApp): bool {
 		if ($this->exAppService->enableExAppInternal($exApp)) {
-			$exAppEnabled = $this->requestToExApp($exApp, '/enabled?enabled=1', null, 'PUT', options: ['timeout' => 30]);
+			if ($exApp->getAcceptsDeployId() === $this->dockerActions->getAcceptsDeployId()) {
+				$daemonConfig = $this->daemonConfigService->getDaemonConfigByName($exApp->getDaemonConfigName());
+				$this->dockerActions->initGuzzleClient($daemonConfig);
+				$this->dockerActions->startContainer($this->dockerActions->buildDockerUrl($daemonConfig), $this->dockerActions->buildExAppContainerName($exApp->getAppid()));
+			}
+
+			$exAppEnabled = $this->requestToExApp($exApp, '/enabled?enabled=1', null, 'PUT', options: ['timeout' => 60]);
 			if ($exAppEnabled instanceof IResponse) {
 				$response = json_decode($exAppEnabled->getBody(), true);
 				if (!empty($response['error'])) {
@@ -579,7 +586,7 @@ public function enableExApp(ExApp $exApp): bool {
 	 */
 	public function disableExApp(ExApp $exApp): bool {
 		$result = true;
-		$exAppDisabled = $this->requestToExApp($exApp, '/enabled?enabled=0', null, 'PUT', options: ['timeout' => 30]);
+		$exAppDisabled = $this->requestToExApp($exApp, '/enabled?enabled=0', null, 'PUT', options: ['timeout' => 60]);
 		if ($exAppDisabled instanceof IResponse) {
 			$response = json_decode($exAppDisabled->getBody(), true);
 			if (isset($response['error']) && strlen($response['error']) !== 0) {
@@ -590,6 +597,11 @@ public function disableExApp(ExApp $exApp): bool {
 			$this->logger->error(sprintf('Failed to disable ExApp %s. Error: %s', $exApp->getAppid(), $exAppDisabled['error']));
 			$result = false;
 		}
+		if ($exApp->getAcceptsDeployId() === $this->dockerActions->getAcceptsDeployId()) {
+			$daemonConfig = $this->daemonConfigService->getDaemonConfigByName($exApp->getDaemonConfigName());
+			$this->dockerActions->initGuzzleClient($daemonConfig);
+			$this->dockerActions->stopContainer($this->dockerActions->buildDockerUrl($daemonConfig), $this->dockerActions->buildExAppContainerName($exApp->getAppid()));
+		}
 		$this->exAppService->disableExAppInternal($exApp);
 		return $result;
 	}