Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added "stable28" branch #123

Merged
merged 4 commits into from
Nov 24, 2023
Merged

added "stable28" branch #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d966ab
added "stable28"
bigcat88 Nov 24, 2023
58a7546
fixed bug/typo in CI action with PHP version
bigcat88 Nov 24, 2023
c6b7f3e
allow NC 29 version
bigcat88 Nov 24, 2023
27f508a
fixed bug in test.yml
bigcat88 Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions .github/workflows/node-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
name: Node Build

on:
pull_request:
paths:
- src/**
- .eslintrc.js
- stylelint.config.js
- webpack.js
push:
branches:
- main
paths:
- src/**
- .eslintrc.js
- stylelint.config.js
- webpack.js

jobs:
build:
name: node-build
runs-on: ubuntu-latest

steps:
- name: Set app env
run: echo "APP_NAME=${GITHUB_REPOSITORY##*/}" >> $GITHUB_ENV

- name: Checkout
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab #
with:
path: ${{ env.APP_NAME }}

- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@0ce2ed60f6df073a62a77c0a4958dd0fc68e32e7 # v2.1
id: versions
with:
path: ${{ env.APP_NAME }}
fallbackNode: "^20"
fallbackNpm: "^9"

- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
with:
node-version: ${{ steps.versions.outputs.nodeVersion }}

- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
run: npm i -g npm@"${{ steps.versions.outputs.npmVersion }}"

- name: Build ${{ env.APP_NAME }}
run: |
cd ${{ env.APP_NAME }}
npm ci
npm run build
12 changes: 7 additions & 5 deletions .github/workflows/tests-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ jobs:
php-version: [ '8.1' ]
server-version: [ 'stable27' ]
include:
- server-version: "master"
- server-version: "stable28"
php-version: "8.2"
- server-version: "master"
php-version: "8.3"

services:
postgres:
Expand Down Expand Up @@ -60,10 +62,10 @@ jobs:
with:
path: apps/${{ env.APP_NAME }}

- name: Set up php ${{ matrix.php-versions }}
- name: Set up php ${{ matrix.php-version }}
uses: shivammathur/setup-php@4bd44f22a98a19e0950cbad5f31095157cc9621b # v2
with:
php-version: ${{ matrix.php-versions }}
php-version: ${{ matrix.php-version }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, pgsql, pdo_pgsql
coverage: none
ini-file: development
Expand Down Expand Up @@ -419,10 +421,10 @@ jobs:
with:
path: apps/${{ env.APP_NAME }}

- name: Set up php ${{ matrix.php-versions }}
- name: Set up php ${{ matrix.php-version }}
uses: shivammathur/setup-php@4bd44f22a98a19e0950cbad5f31095157cc9621b # v2
with:
php-version: ${{ matrix.php-versions }}
php-version: ${{ matrix.php-version }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, pgsql, pdo_pgsql, redis
coverage: none
ini-file: development
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ jobs:
php-version: [ '8.1' ]
server-version: [ 'stable27' ]
include:
- server-version: "master"
- server-version: "stable28"
php-version: "8.2"
- server-version: "master"
php-version: "8.3"
env:
NEXTCLOUD_URL: "http://localhost:8080/"
APP_ID: "nc_py_api"
Expand Down Expand Up @@ -71,10 +73,10 @@ jobs:
with:
path: apps/${{ env.APP_NAME }}

- name: Set up php ${{ matrix.php-versions }}
- name: Set up php ${{ matrix.php-version }}
uses: shivammathur/setup-php@4bd44f22a98a19e0950cbad5f31095157cc9621b # v2
with:
php-version: ${{ matrix.php-versions }}
php-version: ${{ matrix.php-version }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, pgsql, pdo_pgsql
coverage: none
ini-file: development
Expand Down
2 changes: 1 addition & 1 deletion appinfo/info.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ to join us in shaping a more versatile, stable, and secure app landscape.
<screenshot>https://raw.githubusercontent.com/cloud-py-api/app_api/main/screenshots/app_api_admin_settings.png</screenshot>
<dependencies>
<php min-version="8.1"/>
<nextcloud min-version="27" max-version="28"/>
<nextcloud min-version="27" max-version="29"/>
</dependencies>
<repair-steps>
<install>
Expand Down