ExApp UI Implementation (Part1) #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
…enable/disable app process.
andrey18106
approved these changes
Dec 3, 2023
bigcat88
added a commit
to cloud-py-api/nc_py_api
that referenced
this pull request
Dec 3, 2023
Reference: nextcloud/app_api#135 First part. * Added API for UI, Example(not finished yet). Missing: * Example and description how to use it in docs, and example in example folder is not fully finished. --------- Signed-off-by: Alexander Piskun <[email protected]> Signed-off-by: Andrey Borysenko <[email protected]> Co-authored-by: Andrey Borysenko <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
bigcat88
added a commit
that referenced
this pull request
Dec 3, 2023
Changes proposed in this PR(first part is here #135): CI: * added Oracle CI test, as previous PR created a new error with Oracle DB due to missing tests * TopMenu: icon_url -> icon Bugs: * do not spam error into log file in **getExAppFileAction**, **getExAppMenuEntry** * Oracle fix for FileAction entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability for ExApp to have entry in TopMenu and provide it's own page when clicking on it.
PR is ready, after merging this, one additional PR will be created that relates to this one.
That PR will cover missing parts:
js/proxy_jsfolderMerging this PR will allow nc_py_api's PR to be finished on this theme and finish first example for testing.