Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Deploy" removed, Register Rework #233

Merged
merged 17 commits into from
Feb 19, 2024
Merged

"Deploy" removed, Register Rework #233

merged 17 commits into from
Feb 19, 2024

Conversation

bigcat88
Copy link
Member

@bigcat88 bigcat88 commented Feb 16, 2024

PR should not break anything, for old parts added a workarounds, that we will remove in a month when all ExApps will publish their updates.

Changes:

  • UI now use the same algorithm/code for ExApp register & update as the CLI commands.
  • Deprecated "deploy" command, now register commands performs deploy.

Refactoring:

  • Removed internal DispatchInit command, as from CLI we already can do it without spawning additional process.
  • Removed hack(status['active']) when we have some half-enabled state of ExApp when it is not enabled, but already can call APIs, now ExApp enables before calling /init
  • Made code more consistent in many place.

OTHER CHANGES FOR DEVS:

  • For --json-info parameter in occ register command keys renamed: "appid" -> "id", "system_app" -> "system"

    Old naming is still supported but will be removed in future, in such way we make consistent parameters between info.xml and --json-info.


Related: #219
AppAPI will perform deploy & registration in a background and issue should be fixed

@bigcat88
Copy link
Member Author

image

Updated docs

@bigcat88
Copy link
Member Author

image

If an error occurs during "Registration" when retrieving an image, the ExApp will be unregistered. The frontend continues to spam about errors, although it is enough to say once that there was an error.
And if ExApp is present then display the info from status['error'] or if ExApp is missing then just: "check logs" string.

@bigcat88
Copy link
Member Author

Second/third issue(s):

When I press "Deploy and Enable" I see that progress go and I made a page refresh(F5).
Button "Remove" appeared near the progress what I think is should not happen?

Also after that UI stopped on ending progress and ExAPP in UI do not reach "Enabled" state.

@bigcat88 bigcat88 marked this pull request as ready for review February 19, 2024 14:52
Signed-off-by: Alexander Piskun <[email protected]>
@andrey18106 andrey18106 merged commit c7d1c3e into main Feb 19, 2024
29 checks passed
@andrey18106 andrey18106 deleted the remove-deploy-cmd branch February 19, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants