Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(initial-state): correct defaultDaemonConfig initial state #473

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

andrey18106
Copy link
Collaborator

There is was missing check if no deploy daemons configured, null value produced warning logs.

Resolves: #472

@andrey18106 andrey18106 requested a review from bigcat88 December 17, 2024 14:43
@andrey18106
Copy link
Collaborator Author

/backport to stable30

Copy link
Contributor

@oleksandr-nc oleksandr-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I hope the frontend will handle the missing defaultDaemonConfig correctly

Don't forget to increase the version in a separate PR, for the stable30 branch, so that it is the same minor as the server

@andrey18106 andrey18106 merged commit 280d887 into main Dec 23, 2024
30 checks passed
@andrey18106 andrey18106 deleted the fix/settings-initial-state branch December 23, 2024 15:12
Copy link

backportbot bot commented Dec 23, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/473/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bd447b8d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/473/stable30

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Warning message in log (defaultDaemonConfig) when navigating to "Applications" tab and submenu
2 participants