Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max-width for long timezones names #6613

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jan 8, 2025

fixes #6570

to avoid any breaking changes on other parts where ncselect is used, lets force it on calendar

Screenshot from 2025-01-08 12-39-08

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.41%. Comparing base (8f9e504) to head (c27f067).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6613   +/-   ##
=========================================
  Coverage     23.41%   23.41%           
  Complexity      472      472           
=========================================
  Files           249      249           
  Lines         11899    11899           
  Branches       2269     2268    -1     
=========================================
  Hits           2786     2786           
  Misses         8786     8786           
  Partials        327      327           
Flag Coverage Δ
javascript 14.85% <ø> (ø)
php 59.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD GretaD self-assigned this Jan 8, 2025
@GretaD GretaD added the 3. to review Waiting for reviews label Jan 8, 2025
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd scope it into .booking__time-zone to make sure it doesn't affect anything else that would be added afterwards.

@GretaD GretaD force-pushed the fix/appointment-timezone-width branch from bb45ba5 to c27f067 Compare January 8, 2025 14:18
@GretaD GretaD merged commit fea77aa into main Jan 8, 2025
38 checks passed
@GretaD GretaD deleted the fix/appointment-timezone-width branch January 8, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Appointment Schedule view breaks with some selected time zones
2 participants