Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Set CSS variable --text-editor-max-width per default #967

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Oct 26, 2023

Otherwise we break the layout of Text in Viewer (e.g. when opening a linked file in the viewer).

πŸ–ΌοΈ Screenshots (linked text file opened in Viewer)

🏚️ Before 🏑 After
grafik grafik

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

Otherwise we break the layout of Text in Viewer (e.g. when opening
a linked file in the viewer).

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- force-pushed the fix/text_editor_max_width branch from 0dd00cf to 1fb0d05 Compare October 27, 2023 08:34
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

One thing i wonder though is wether we really need this css class in so many places and can't have an ancestor with that class and corresponding selectors - but that's a whole different discussion.

@mejo- mejo- merged commit ce6bf90 into main Oct 30, 2023
39 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/text_editor_max_width branch October 30, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants