Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui/tray: Remove BasicComboBox QML component, prefer native component #7583

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

claucambra
Copy link
Collaborator

No description provided.

@claucambra claucambra added this to the 3.16.0 milestone Nov 28, 2024
@claucambra claucambra self-assigned this Nov 28, 2024
@claucambra claucambra changed the title Remove BasicComboBox QML component, prefer native component gui/tray: Remove BasicComboBox QML component, prefer native component Nov 28, 2024
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference ?
visual one ?
behavior ?

@claucambra
Copy link
Collaborator Author

claucambra commented Jan 10, 2025

what is the difference ? visual one ? behavior ?

We now have native styling for combo boxes (we were only using this in one place, the user status selector view)

@mgallien mgallien enabled auto-merge January 10, 2025 17:10
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7583-1c68012ac3f3e147c3452472f0e38360e7b9dec6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 042568c into master Jan 10, 2025
14 of 17 checks passed
@mgallien mgallien deleted the bugfix/remove-bcc branch January 10, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants