Fix path to image resources

When "./js/pdfjs/web/images/" is resolved and pretty URLs are enabled the result is "{SERVER}/apps/files_pdfviewer/js/pdfjs/web/images/", which works as expected. However, if pretty URLs are not enabled the absolute path becomes "{SERVER}/index.php/apps/files_pdfviewer/js/pdfjs/web/images/" instead. As the images are static files they are not served by "index.php", so they can not be found and therefore are not rendered in the PDF. To solve that now the path is generated in PHP and provided through the template, similarly to how it is done, for example, for the path to the cmap files. Signed-off-by: Daniel Calviño Sánchez <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud · Jan 14, 2025 · 81fb907 · 81fb907
1 parent 3e6e54b
commit 81fb907
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/js/files_pdfviewer-workersrc.js b/js/files_pdfviewer-workersrc.js
diff --git a/js/files_pdfviewer-workersrc.js.map b/js/files_pdfviewer-workersrc.js.map
diff --git a/src/workersrc.js b/src/workersrc.js
@@ -29,7 +29,7 @@ function initializeCustomPDFViewerApplication() {
 	PDFViewerApplicationOptions.set('cMapUrl', head.getAttribute('data-cmapurl'))
 	PDFViewerApplicationOptions.set('sandboxBundleSrc', head.getAttribute('data-sandbox'))
 	PDFViewerApplicationOptions.set('enablePermissions', true)
-	PDFViewerApplicationOptions.set('imageResourcesPath', './js/pdfjs/web/images/')
+	PDFViewerApplicationOptions.set('imageResourcesPath', head.getAttribute('data-imageresourcespath'))
 	PDFViewerApplicationOptions.set('enableScripting', head.getAttribute('data-enableScripting') === true)
 
 	if (hideDownload === '1') {

diff --git a/templates/viewer.php b/templates/viewer.php
@@ -42,7 +42,8 @@
   <head data-workersrc="<?php p($urlGenerator->linkTo('files_pdfviewer', 'js/pdfjs/build/pdf.worker.js')) ?>?v=<?php p($version) ?>"
         data-enableScripting="<?php p($enableScripting ? true : false) ?>"
         data-sandbox="<?php p($urlGenerator->linkTo('files_pdfviewer', 'js/pdfjs/build/pdf.sandbox.js'))?>"
-        data-cmapurl="<?php p($urlGenerator->linkTo('files_pdfviewer', 'js/pdfjs/web/cmaps/')) ?>">
+        data-cmapurl="<?php p($urlGenerator->linkTo('files_pdfviewer', 'js/pdfjs/web/cmaps/')) ?>"
+        data-imageresourcespath="<?php p($urlGenerator->linkTo('files_pdfviewer', 'js/pdfjs/web/images/')) ?>">
     <meta charset="utf-8">
     <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1">
     <meta name="google" content="notranslate">