Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New first run wizard #960

Merged
merged 1 commit into from
Nov 2, 2023
Merged

New first run wizard #960

merged 1 commit into from
Nov 2, 2023

Conversation

marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Oct 6, 2023 •
edited by susnux
Loading

Close #888

TODO:

  • re-add video and automatically move to second slide after it is finished?
  • shorten the video/audio?
  • check with marketing if all messages are in
  • change Other Downloads to Calendar and contacts with subline Connect your calendar and contacts with your devices
  • Audio doesn't work
  • Fix sync clients settings section
  • max-contrast-text add version number (maybe as subline in last slide=
  • on page 2-3 circle on top should only be line like in text
  • allow to navigate slides with arrow buttons?
  • ask for final a11y review
  • Re-add 3 seconds webm video
  • address comments
  • fix styling of video (should have rounded corners)
  • Fix styling of buttons in settings (currently broken on master as well)
  • fix layout problems (shrinking, mobile)
  • squash
  • rebase
  • test on different screen resolutions
  • fix tests
  • merge
Sneakpeak
Aufzeichnung.2023-11-02.131725.mp4

@szaimen szaimen added this to the Nextcloud 28 milestone Oct 6, 2023
szaimen
szaimen reviewed Oct 6, 2023
View reviewed changes
img/info.svg Outdated Show resolved Hide resolved
szaimen
szaimen reviewed Oct 6, 2023
View reviewed changes
src/components/Page0.vue Outdated Show resolved Hide resolved
@szaimen szaimen mentioned this pull request Oct 6, 2023
Closed
@marcoambrosini marcoambrosini force-pushed the feature/new-first-run-wizard branch from 7c3d73b to 07928d2 Compare October 11, 2023 07:58
szaimen
szaimen reviewed Oct 11, 2023
View reviewed changes
css/personalsettings.css Outdated Show resolved Hide resolved
szaimen
szaimen reviewed Oct 12, 2023
View reviewed changes
.DS_Store Outdated Show resolved Hide resolved
szaimen
szaimen reviewed Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

src/components/Card.vue Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/components/AppStoreBadge.vue Outdated Show resolved Hide resolved
@jancborchardt
Copy link
Member

@schiessle so at some point we added the version number to the first slide so people easily find it. With the new design we want to keep it a bit cleaner, would it be ok if we have the version number only on the last/third slide?

@jancborchardt
Copy link
Member

@szaimen @marcoambrosini regarding the video point:

re-add video and automatically move to second slide after it is finished?

Thought about it a bit more and yes, let’s add it back and automatically move on to the second slide when it is finished. @szaimen regarding your point that it will not be themed:

  • The default experience is still the main goal, and that looks much better with the video
  • It is some advertisement for Nextcloud which is nice
  • If people want to theme it out or rather replace it with their own video they can
  • If we really want to make it look nice and themed, we could do a CSS animation in the beginning. This is something for the future though, nothing immediate. :) (Also it has to be done very well for it to look as good as the video.)

@schiessle
Copy link
Member

@schiessle so at some point we added the version number to the first slide so people easily find it. With the new design we want to keep it a bit cleaner, would it be ok if we have the version number only on the last/third slide?

would be fine for me.

@marcoambrosini marcoambrosini force-pushed the feature/new-first-run-wizard branch from 9dff0a3 to 9b03a8f Compare November 1, 2023 08:19
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@marcoambrosini
Copy link
Member Author

@nextcloud/a11y-review could you please give us an accessibility review of this? Thanks :)

ShGKme
ShGKme reviewed Nov 1, 2023
View reviewed changes
src/components/AppStoreBadge.vue Outdated Show resolved Hide resolved
src/components/Card.vue Outdated Show resolved Hide resolved
src/components/Card.vue Show resolved Hide resolved
@marcoambrosini marcoambrosini force-pushed the feature/new-first-run-wizard branch from 258b4aa to c0079b9 Compare November 2, 2023 09:08
@marcoambrosini marcoambrosini marked this pull request as ready for review November 2, 2023 09:10
szaimen
szaimen reviewed Nov 2, 2023
View reviewed changes
tests/Controller/WizardControllerTest.php
Comment on lines -108 to -112
['customclient_desktop', 'https://nextcloud.com/install/#install-clients', 'https://nextcloud.com/install/#install-clients'],
['customclient_android', 'https://play.google.com/store/apps/details?id=com.nextcloud.client', 'https://nextcloud.com/install/#install-clients'],
['customclient_fdroid', 'https://f-droid.org/packages/com.nextcloud.client/', 'https://nextcloud.com/install/#install-clients'],
['customclient_ios', 'https://geo.itunes.apple.com/us/app/nextcloud/id1125420102?mt=8', 'https://nextcloud.com/install/#install-clients'],
['appstoreenabled', true, true]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoambrosini I fixed the tests. However we should probably re-introduce this so that customers can adjust the links. Should we do this still in this PR or rather in a follow-up like the transitions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put it into #985

@szaimen szaimen force-pushed the feature/new-first-run-wizard branch from 15f3410 to 5d3d8f1 Compare November 2, 2023 10:14
szaimen
szaimen reviewed Nov 2, 2023
View reviewed changes
src/App.vue Show resolved Hide resolved
@szaimen szaimen force-pushed the feature/new-first-run-wizard branch from 5d3d8f1 to 53ac2d7 Compare November 2, 2023 12:06
@szaimen szaimen mentioned this pull request Nov 2, 2023
Closed
2 tasks
@szaimen szaimen force-pushed the feature/new-first-run-wizard branch from 53ac2d7 to 65fd174 Compare November 2, 2023 12:42
@szaimen
Copy link
Collaborator

szaimen commented Nov 2, 2023

/compile amend /

@marcoambrosini @nextcloud-command
New first-run wizard
40c0881 
Signed-off-by: Marco <[email protected]>
Signed-off-by: Simon L <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the feature/new-first-run-wizard branch from 65fd174 to 40c0881 Compare November 2, 2023 14:03
@szaimen szaimen disabled auto-merge November 2, 2023 14:52
@szaimen
Copy link
Collaborator

szaimen commented Nov 2, 2023

CI failure unrelated

@szaimen szaimen merged commit 84b3a24 into master Nov 2, 2023
26 of 28 checks passed
@szaimen szaimen deleted the feature/new-first-run-wizard branch November 2, 2023 14:53
@szaimen
Copy link
Collaborator

szaimen commented Nov 2, 2023

🎉🎉🎉🎉🎉

nickvergessen
nickvergessen reviewed Nov 10, 2023
View reviewed changes
img/user.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is still used in notifications which are currently broken…

image not found: image:user.svg webroot: serverroot:/var/www/…

Was deletion intentional?
Will restore in a new PR.

@ChristophWurst ChristophWurst mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@ShGKme ShGKme ShGKme left review comments

@nickvergessen nickvergessen nickvergessen left review comments

Assignees

@marcoambrosini marcoambrosini

@szaimen szaimen

Labels
3. to review design enhancement
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Update design (and possibly content) of first run wizard slides
6 participants
@marcoambrosini @jancborchardt @schiessle @szaimen @nickvergessen @ShGKme