Merge pull request #1286 from nextcloud/fix/dynamite-e2e/fix-spec-que…

…ry-parameter-escaping fix(dynamite_end_to_end_test): do not use special characters in query…
nextcloud · Dec 13, 2023 · 099a3b8 · 099a3b8
2 parents c54bce9 + 7d6bbc4
commit 099a3b8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/packages/dynamite/dynamite_end_to_end_test/lib/parameters.openapi.dart b/packages/dynamite/dynamite_end_to_end_test/lib/parameters.openapi.dart
@@ -85,15 +85,15 @@ class Client extends DynamiteClient {
     Uint8List? body;
 
     if (contentString != null) {
-      queryParameters['content-string'] = jsonSerializers.serialize(
+      queryParameters['content_string'] = jsonSerializers.serialize(
         contentString,
         specifiedType: const FullType(ContentString, [
           FullType(BuiltMap, [FullType(String), FullType(JsonObject)]),
         ]),
       );
     }
     if (contentParameter != null) {
-      queryParameters['content-parameter'] = jsonSerializers.serialize(
+      queryParameters['content_parameter'] = jsonSerializers.serialize(
         contentParameter,
         specifiedType: const FullType(ContentString, [
           FullType(BuiltMap, [FullType(String), FullType(JsonObject)]),

diff --git a/packages/dynamite/dynamite_end_to_end_test/lib/parameters.openapi.json b/packages/dynamite/dynamite_end_to_end_test/lib/parameters.openapi.json
@@ -9,7 +9,7 @@
             "get": {
                 "parameters": [
                     {
-                        "name": "content-string",
+                        "name": "content_string",
                         "in": "query",
                         "schema": {
                             "type": "string",
@@ -21,7 +21,7 @@
                         }
                     },
                     {
-                        "name": "content-parameter",
+                        "name": "content_parameter",
                         "in": "query",
                         "content": {
                             "application/json": {

diff --git a/packages/dynamite/dynamite_end_to_end_test/test/parameters_test.dart b/packages/dynamite/dynamite_end_to_end_test/test/parameters_test.dart
@@ -66,7 +66,7 @@ void main() {
         captured,
         equals([
           'get',
-          Uri.parse('example.com/?content-string=$queryComponent'),
+          Uri.parse('example.com/?content_string=$queryComponent'),
         ]),
       );
     });
@@ -84,7 +84,7 @@ void main() {
         captured,
         equals([
           'get',
-          Uri.parse('example.com/?content-parameter=$queryComponent'),
+          Uri.parse('example.com/?content_parameter=$queryComponent'),
         ]),
       );
     });
@@ -102,7 +102,7 @@ void main() {
         captured,
         equals([
           'get',
-          Uri.parse('example.com/?content-string=$queryComponent&content-parameter=$queryComponent'),
+          Uri.parse('example.com/?content_string=$queryComponent&content_parameter=$queryComponent'),
         ]),
       );
     });