feat(dynamite): introduce dynamite config to set ignore directives #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
approved these changes
Oct 29, 2023
Leptopoda
force-pushed
the
feat/dynamite/config
branch
from
9320e4c to
42db03f
Compare
provokateurin
requested changes
Oct 29, 2023
packages/dynamite/dynamite/lib/src/models/dynamite_config/config.dart
Outdated
Show resolved
Hide resolved
Leptopoda
force-pushed
the
feat/dynamite/config
branch
from
42db03f to
5084166
Compare
Leptopoda
force-pushed
the
feat/dynamite/config
branch
from
5084166 to
6d71676
Compare
provokateurin
requested changes
Oct 29, 2023
Signed-off-by: Nikolas Rimikis <[email protected]>
Leptopoda
force-pushed
the
feat/dynamite/config
branch
from
6d71676 to
d74f8df
Compare
provokateurin
approved these changes
Oct 29, 2023
This was referenced Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably first wait for #1024
I hope that we can leverage the config more in the future. I disabled coverage ignores in the dynamite_e2e tests as we should get the real data once coverage reports are set up.