Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamite): resolve arrays with a maximum length of 0 to BuiltList… #1223

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

Leptopoda
Copy link
Member

Fixes the issue we had with nextcloud and #1058.
This does not solve the root cause of the issue.

@Leptopoda Leptopoda force-pushed the fix/dynamite/array_zero_max_length branch from 73297b7 to 7286ee7 Compare December 3, 2023 17:30
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that ensures an error is thrown when trying to deserialize a non-empty array

@provokateurin
Copy link
Member

user_status also has a patch that needs to be removed and please rename the remaining spreed patches so they start with 0 again.

@Leptopoda Leptopoda force-pushed the fix/dynamite/array_zero_max_length branch from 7286ee7 to a1a626c Compare December 4, 2023 09:30
@Leptopoda Leptopoda merged commit 76e4d5f into main Dec 4, 2023
9 checks passed
@Leptopoda Leptopoda deleted the fix/dynamite/array_zero_max_length branch December 4, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants