Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dynamite): do not await writing the output string. #1229

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix(dynamite): do not await writing the output string. #1229

merged 1 commit into from
Dec 4, 2023

Conversation

Leptopoda
Copy link
Member

from the dart builder documentation:

NOTE: Most Builder implementations should not need to await this Future since the runner will be responsible for waiting until all outputs are written.

@Leptopoda Leptopoda enabled auto-merge December 4, 2023 20:58
@Leptopoda Leptopoda merged commit 0807b4f into main Dec 4, 2023
9 checks passed
@Leptopoda Leptopoda deleted the fix/dynamite/do_not_await_writing_outputs branch December 4, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leptopoda @provokateurin