Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update plugin com.android.application to v8 #1258

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 8, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.android.application (source) 7.4.2 -> 8.3.1 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies label Dec 8, 2023
@renovate renovate bot force-pushed the renovate/com.android.application-8.x branch from 425365e to 6217fd7 Compare December 8, 2023 20:04
@provokateurin
Copy link
Member

Ok so this one is still broken now 😞

@provokateurin provokateurin marked this pull request as draft December 8, 2023 20:06
@provokateurin
Copy link
Member

open_file package seems to be the problem:

Failed to query the value of property 'buildFlowServiceProperty'.
> Could not isolate value org.jetbrains.kotlin.gradle.plugin.statistics.BuildFlowService$Parameters_Decorated@3b3263dc of type BuildFlowService.Parameters
   > A problem occurred configuring project ':open_file'.
      > Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
         > Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

           If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

It doesn't look very maintained, maybe we should switch to a different package.

@renovate renovate bot force-pushed the renovate/com.android.application-8.x branch from 6217fd7 to f14b669 Compare January 3, 2024 18:34
@renovate renovate bot force-pushed the renovate/com.android.application-8.x branch from f14b669 to bd9a990 Compare January 23, 2024 18:53
@provokateurin
Copy link
Member

@Leptopoda shall we use crazecoder/open_file#272 for now to finally get this upgrade?

@Leptopoda
Copy link
Member

I'm fine with it.

@provokateurin
Copy link
Member

Meh next blocker is some trouble with https://github.com/MaikuB/flutter_local_notifications/tree/master/flutter_local_notifications and desugaring which I have no clue about. The suggested workarounds didn't work.

@provokateurin provokateurin added help wanted Extra attention is needed blocked Blocked on other things labels Jan 31, 2024
@renovate renovate bot force-pushed the renovate/com.android.application-8.x branch from bd9a990 to 9b95c63 Compare February 29, 2024 18:34
@renovate renovate bot force-pushed the renovate/com.android.application-8.x branch from 9b95c63 to 9ac8518 Compare March 18, 2024 20:07
@provokateurin provokateurin marked this pull request as ready for review March 20, 2024 19:32
@provokateurin provokateurin force-pushed the renovate/com.android.application-8.x branch from 9ac8518 to 708651e Compare March 20, 2024 19:32
@provokateurin provokateurin requested a review from Leptopoda March 20, 2024 19:32
Copy link
Contributor Author

renovate bot commented Mar 20, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@provokateurin provokateurin force-pushed the renovate/com.android.application-8.x branch from 708651e to 04f2209 Compare March 20, 2024 19:40
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finally finding a fix.
open_filex looks promising ❤️

@provokateurin provokateurin merged commit 923d6ee into main Mar 22, 2024
8 checks passed
@provokateurin provokateurin deleted the renovate/com.android.application-8.x branch March 22, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on other things dependencies help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants