-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dynamite_runtime): fix last pana complaints for the 0.1.0 release #1349
Conversation
Ah and we still can't automatically add the petstore example. For now I just copied the contents to the example directories and adjusted the pubspec_overrides. Long term we should have CI/CD for that. |
pana complains that web is not supported in dynamite_runtime, but it is because we are using universal_io. Please add this to the pubspec: platforms:
windows:
linux:
macos:
android:
ios:
web: For dynamite configuring the platforms doesn't really make sense, but we could limit it to linux, macos and windows |
Even though it's stupid, we could just always copy the package to the example folders when generating it. Then we have 3 copies in the repo. We could also just make it the example package of dynamite. For dynamite_runtime we don't really need to care about the score. This would be cleaner imo |
I'd rather do that and drop the other packages. |
Yeah please point it to the path as well. |
Why not just switch it around so the homepage points to the root? |
Pana will try to check for the package using the repository url. I'm not sure how it is supposed to be used, so please just do what pana wants us to do. |
8375675
to
05131a9
Compare
Ok cspell needs adjusting but review is appreciated. |
66c1879
to
a094ca0
Compare
any news here? |
please rebase |
and run pana again |
a094ca0
to
69c89c6
Compare
Pana still complains about the pubspec and the missing changelog. |
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Can you rebase and push the issue tracker fix? Then this is ready to be merged |
69c89c6
to
5a63947
Compare
I'm not sure whether the repository url should really point to the root repo.
both json_serializable and built_value (to name two larger monorepos) point the repo url to the directory the package lives in:
https://github.com/google/json_serializable.dart/blob/master/json_serializable/pubspec.yaml
https://github.com/google/built_value.dart/blob/master/built_value/pubspec.yaml
Attached are the pana results but the only remaining issue is that pana can't find the package in the clone of the root repository 🤷♀️
dynamite_pana.txt
dynamite_runtime_pana.txt