fix(neon_framework): Remove progress indicator height jumping around #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jld3103 <[email protected]>
Leptopoda
approved these changes
Dec 24, 2023
|
Nope, that one is about the images actually reloading and not just jumping up and down a few pixels. |
provokateurin
deleted the
fix/neon_framework/progress-indicator-jumping
branch
|
I just thought that by not needing to re layout the list view this would also fix this one at the same time :( |
|
Wait let me check, maybe it does fix it. I just thought it wouldn't because I did it to fix a different thing. |
|
Nope it doesn't fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always want to display it with the exact height to prevent items in a listview or column from jumping around because of the height difference.