Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neon_talk): Display icon next to deleted messages #1826

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

provokateurin
Copy link
Member

Makes it a lot clearer that it is not a normal chat message.

@provokateurin provokateurin requested a review from Leptopoda March 27, 2024 18:04
@provokateurin provokateurin force-pushed the feat/neon_talk/deleted-message-icon branch from 7c8502b to d9eeeba Compare March 27, 2024 18:10
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 44.63%. Comparing base (d49045a) to head (955e6eb).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1826      +/-   ##
==========================================
+ Coverage   44.55%   44.63%   +0.07%     
==========================================
  Files         114      114              
  Lines        3795     3802       +7     
==========================================
+ Hits         1691     1697       +6     
- Misses       2104     2105       +1     
Files Coverage Δ
...ckages/neon/neon_talk/lib/src/widgets/message.dart 100.00% <100.00%> (ø)
packages/neon_framework/lib/src/theme/icons.dart 16.21% <0.00%> (-0.46%) ⬇️

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% convinced by the design:

  1. the icon is bigger than the text
  2. there should be a space between the icon and the icon and the text for better readability

@provokateurin provokateurin force-pushed the feat/neon_talk/deleted-message-icon branch from d9eeeba to 7ca08fa Compare March 27, 2024 23:35
@provokateurin provokateurin requested a review from Leptopoda March 27, 2024 23:36
@provokateurin provokateurin force-pushed the feat/neon_talk/deleted-message-icon branch from 7ca08fa to 955e6eb Compare March 28, 2024 08:22
@provokateurin provokateurin requested a review from Leptopoda March 28, 2024 08:22
@provokateurin provokateurin merged commit 1d46c3b into main Mar 28, 2024
10 checks passed
@provokateurin provokateurin deleted the feat/neon_talk/deleted-message-icon branch March 28, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants