-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): melos variable substitution for the codecov upload step #1831
Conversation
How is this supposed to work without any |
melos magc (see the linked docs). It's stupid I know. I was not able to get it working with the proper |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1831 +/- ##
=======================================
Coverage 44.63% 44.63%
=======================================
Files 114 114
Lines 3802 3802
=======================================
Hits 1697 1697
Misses 2105 2105
|
ca91009
to
2184203
Compare
It must have been something with the double quoting. After removing them it also works with the |
Report is still empty 🤔 |
Signed-off-by: Nikolas Rimikis <[email protected]>
2184203
to
2b37288
Compare
Ok we really need to remove the dollar signs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The report finally looks good 👍
Don't forget to remove the test commit! |
2b37288
to
a06f47b
Compare
Somewhere in the changes yesterday the variable substitution broke.
For whatever stupid reason melos will inject them when not specified with a
$
sign.https://melos.invertase.dev/environment-variables