Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): melos variable substitution for the codecov upload step #1831

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

Leptopoda
Copy link
Member

Somewhere in the changes yesterday the variable substitution broke.
For whatever stupid reason melos will inject them when not specified with a $ sign.
https://melos.invertase.dev/environment-variables

@Leptopoda Leptopoda requested a review from provokateurin March 28, 2024 10:42
@provokateurin
Copy link
Member

How is this supposed to work without any $ at all?

@Leptopoda
Copy link
Member Author

melos magc (see the linked docs). It's stupid I know.

I was not able to get it working with the proper $ variables (although I would prefer using them).

.github/workflows/dart.yml Outdated Show resolved Hide resolved
.github/workflows/dart.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.63%. Comparing base (955e6eb) to head (2b37288).
Report is 12 commits behind head on main.

❗ Current head 2b37288 differs from pull request most recent head a06f47b. Consider uploading reports for the commit a06f47b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1831   +/-   ##
=======================================
  Coverage   44.63%   44.63%           
=======================================
  Files         114      114           
  Lines        3802     3802           
=======================================
  Hits         1697     1697           
  Misses       2105     2105           
Flag Coverage Δ
neon_dashboard 92.56% <ø> (?)
neon_framework 37.36% <ø> (?)
neon_talk 100.00% <ø> (?)

@Leptopoda Leptopoda force-pushed the fix/tools/codecov_coverage_upload branch from ca91009 to 2184203 Compare March 28, 2024 11:18
@Leptopoda
Copy link
Member Author

It must have been something with the double quoting. After removing them it also works with the $ sign.
Let's see

@provokateurin
Copy link
Member

Report is still empty 🤔

@Leptopoda Leptopoda force-pushed the fix/tools/codecov_coverage_upload branch from 2184203 to 2b37288 Compare March 28, 2024 14:47
@Leptopoda
Copy link
Member Author

Ok we really need to remove the dollar signs.

@Leptopoda Leptopoda requested a review from provokateurin March 28, 2024 15:54
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The report finally looks good 👍

@provokateurin
Copy link
Member

Don't forget to remove the test commit!

@Leptopoda Leptopoda force-pushed the fix/tools/codecov_coverage_upload branch from 2b37288 to a06f47b Compare March 29, 2024 09:57
@Leptopoda Leptopoda enabled auto-merge March 29, 2024 09:59
@Leptopoda Leptopoda merged commit 1726652 into main Mar 29, 2024
8 checks passed
@Leptopoda Leptopoda deleted the fix/tools/codecov_coverage_upload branch March 29, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants