feat(nextcloud)!: deserialize webdav date fields

[Leptopoda]

No description provided.

[provokateurin]

Cool stuff!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.63%. Comparing base (67a122a) to head (0b2deb1).
Report is 2 commits behind head on main.

❗ Current head 0b2deb1 differs from pull request most recent head d10b22a. Consider uploading reports for the commit d10b22a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
- Coverage   44.67%   44.63%   -0.05%     
==========================================
  Files         114      114              
  Lines        3805     3802       -3     
==========================================
- Hits         1700     1697       -3     
  Misses       2105     2105              

Flag	Coverage Δ
neon_dashboard	92.56% <ø> (ø)
neon_framework	37.36% <ø> (ø)
neon_talk	100.00% <ø> (ø)

see 1 file with indirect coverage changes

[provokateurin]

Wait you also changed the int/bool fields?

[Leptopoda]

yep. Why?
I only changed it where the docs said it's either 1 or 0

[provokateurin]

But will it serialize correctly? Because the server might not accept a true instead of a 1 (I didn't test that though).

[Leptopoda]

You're right.
I also only checked the code for deserialization.

[provokateurin]

According to https://www.w3.org/TR/xmlschema-2/#boolean it should work because all those representations are possible. If this turns out to be true then the server docs should be changed to clearly state that the values are not integers but actually booleans.

[provokateurin]

oc:favorite should also be bool.
At least the favorites prop handles all representations correctly: https://github.com/nextcloud/server/blob/c0d21b44437d6ff0ef4ffa08096f18c1e4870fcc/apps/dav/lib/Connector/Sabre/TagsPlugin.php#L285

[provokateurin]

Ok I had a look at all the boolean fields except for oc:favorite they are all dead props meaning the client can't update them. oc:favorite has the correct handling, so everything looks good!

[provokateurin]

I already had the changes for oc:favorite for local testing, so I just pushed them. Please squash and rebase and then we are good to go.

[Leptopoda]

Thanks for taking a look