Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neon_framework): Stop loading forecast in weather status without location #1868

Conversation

provokateurin
Copy link
Member

Fixes #1555

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.39%. Comparing base (b6f3965) to head (a0fcf7c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1868   +/-   ##
=======================================
  Coverage   28.38%   28.39%           
=======================================
  Files         201      201           
  Lines       67322    67328    +6     
=======================================
+ Hits        19109    19115    +6     
  Misses      48213    48213           
Flag Coverage Δ *Carryforward flag
dynamite 35.88% <ø> (ø) Carriedforward from b6f3965
dynamite_end_to_end_test 60.88% <ø> (ø) Carriedforward from b6f3965
dynamite_runtime 57.68% <ø> (ø) Carriedforward from b6f3965
neon_dashboard 92.56% <ø> (ø)
neon_framework 37.44% <100.00%> (+0.11%) ⬆️
neon_talk 100.00% <ø> (ø)
nextcloud 25.69% <ø> (ø) Carriedforward from b6f3965

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...s/neon_framework/lib/src/blocs/weather_status.dart 100.00% <100.00%> (ø)

@provokateurin provokateurin merged commit 0acbef9 into main Apr 5, 2024
10 checks passed
@provokateurin provokateurin deleted the fix/neon_framework/weather-status-forecast-without-location branch April 5, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not try to load forecast without a location being set
2 participants