Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextcloud): Support systemtags and user_ldap apps #1870

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

provokateurin
Copy link
Member

No description provided.

@provokateurin provokateurin requested a review from Leptopoda April 5, 2024 08:12
@provokateurin provokateurin force-pushed the feat/nextcloud/systemtags-user_ldap-apps branch from f6461bd to 1e19cfe Compare April 5, 2024 08:23
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/nextcloud/test/core_test.dart Outdated Show resolved Hide resolved
@provokateurin provokateurin force-pushed the feat/nextcloud/systemtags-user_ldap-apps branch from 1e19cfe to 74c469d Compare April 5, 2024 09:36
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.39%. Comparing base (a0fcf7c) to head (1e19cfe).
Report is 3 commits behind head on main.

❗ Current head 1e19cfe differs from pull request most recent head 74c469d. Consider uploading reports for the commit 74c469d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
- Coverage   28.39%   28.39%   -0.01%     
==========================================
  Files         201      201              
  Lines       67328    67323       -5     
==========================================
- Hits        19115    19113       -2     
+ Misses      48213    48210       -3     
Flag Coverage Δ *Carryforward flag
dynamite 35.88% <ø> (ø) Carriedforward from a0fcf7c
dynamite_end_to_end_test 60.88% <ø> (ø) Carriedforward from a0fcf7c
dynamite_runtime 57.68% <ø> (ø) Carriedforward from a0fcf7c
neon_dashboard 92.56% <ø> (ø)
neon_framework 37.44% <ø> (ø) Carriedforward from a0fcf7c
neon_talk 100.00% <ø> (ø)
nextcloud 25.69% <ø> (-0.01%) ⬇️ Carriedforward from a0fcf7c

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
packages/nextcloud/lib/src/api/core.openapi.dart 42.68% <ø> (+<0.01%) ⬆️
packages/nextcloud/lib/src/api/core.openapi.g.dart 27.20% <ø> (ø)

@provokateurin provokateurin enabled auto-merge April 5, 2024 09:37
@provokateurin provokateurin merged commit 1769b7e into main Apr 5, 2024
8 checks passed
@provokateurin provokateurin deleted the feat/nextcloud/systemtags-user_ldap-apps branch April 5, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants