Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nextcloud): Improve method docs of WebDavClient #2438

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

provokateurin
Copy link
Member

Aligns the documentation of all methods and adds missing docs for parameters (also some slight wording changes).

@provokateurin provokateurin marked this pull request as draft August 29, 2024 09:05
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.21%. Comparing base (4380f5a) to head (a018df2).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2438   +/-   ##
=======================================
  Coverage   27.21%   27.21%           
=======================================
  Files         370      370           
  Lines      136668   136668           
=======================================
  Hits        37192    37192           
  Misses      99476    99476           
Flag Coverage Δ *Carryforward flag
account_repository 99.64% <ø> (ø)
cookie_store 100.00% <ø> (ø) Carriedforward from 4380f5a
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø) Carriedforward from 4380f5a
dynamite_end_to_end_test 61.84% <ø> (ø) Carriedforward from 4380f5a
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 4380f5a
neon_dashboard 96.05% <ø> (ø) Carriedforward from 4380f5a
neon_framework 43.55% <ø> (ø)
neon_http_client 93.28% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 4380f5a
neon_talk 99.45% <ø> (ø) Carriedforward from 4380f5a
nextcloud 23.26% <ø> (ø)
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 4380f5a
talk_app 99.09% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...es/nextcloud/lib/src/api/webdav/webdav_client.dart 99.34% <ø> (ø)

@Leptopoda Leptopoda changed the title feat(nextcloud): Add support for checksums for uploading WebDAV files docs(nextcloud): Improve method docs of WebDavClient Aug 29, 2024
Base automatically changed from feat/nextcloud/webdav-checksums to main August 29, 2024 19:08
@provokateurin provokateurin marked this pull request as ready for review August 29, 2024 19:08
@provokateurin provokateurin merged commit 66e61e3 into main Aug 29, 2024
10 checks passed
@provokateurin provokateurin deleted the docs/nextcloud/webdav-client branch August 29, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants