Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextcloud): Implement WebDAV extended MKCOL #2455

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

provokateurin
Copy link
Member

Closes #512

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 29.89%. Comparing base (4ce78c1) to head (91752b3).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
.../nextcloud/lib/src/api/webdav/models/webdav.g.dart 57.57% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2455      +/-   ##
==========================================
+ Coverage   29.87%   29.89%   +0.02%     
==========================================
  Files         332      332              
  Lines      124330   124348      +18     
==========================================
+ Hits        37138    37171      +33     
+ Misses      87192    87177      -15     
Flag Coverage Δ *Carryforward flag
account_repository 99.64% <ø> (ø)
cookie_store 100.00% <ø> (ø) Carriedforward from 3282a80
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø) Carriedforward from 3282a80
dynamite_end_to_end_test 61.85% <ø> (+0.15%) ⬆️ Carriedforward from 3282a80
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 3282a80
neon_dashboard 96.05% <ø> (ø) Carriedforward from 3282a80
neon_framework 43.55% <ø> (ø)
neon_http_client 93.28% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 3282a80
neon_talk 99.45% <ø> (ø) Carriedforward from 3282a80
nextcloud 25.90% <65.00%> (+0.02%) ⬆️
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 3282a80
talk_app 99.09% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...es/nextcloud/lib/src/api/webdav/models/webdav.dart 86.66% <100.00%> (+0.45%) ⬆️
...es/nextcloud/lib/src/api/webdav/webdav_client.dart 99.34% <100.00%> (ø)
.../nextcloud/lib/src/api/webdav/models/webdav.g.dart 25.49% <57.57%> (+3.44%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no Idea what this is used for but the changes look sane

packages/nextcloud/lib/src/api/webdav/webdav_client.dart Outdated Show resolved Hide resolved
@provokateurin
Copy link
Member Author

I have no Idea what this is used for but the changes look sane

You can simply set props while creating resources (mostly directories). It saves you another request.

@provokateurin provokateurin force-pushed the feat/nextcloud/webdav-extended-mkcol branch from 584347d to 91752b3 Compare August 31, 2024 19:08
@Leptopoda Leptopoda disabled auto-merge August 31, 2024 19:18
@Leptopoda Leptopoda enabled auto-merge August 31, 2024 19:18
@Leptopoda Leptopoda merged commit 5687c01 into main Aug 31, 2024
10 checks passed
@Leptopoda Leptopoda deleted the feat/nextcloud/webdav-extended-mkcol branch August 31, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement extended MKCOL
2 participants