-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tool,neon_framework): Update logo and use adaptive icons #2457
feat(tool,neon_framework): Update logo and use adaptive icons #2457
Conversation
2ea93b8
to
5ea55e0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2457 +/- ##
==========================================
- Coverage 29.89% 27.20% -2.69%
==========================================
Files 332 369 +37
Lines 124348 136655 +12307
==========================================
+ Hits 37171 37179 +8
- Misses 87177 99476 +12299
*This pull request uses carry forward flags. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff LGTM
The only thing is that nextcloud apps use a gradient for the background. Can you also achieve that? Should be fairly simple.
Ok I will give it a try, but it is probably a lot harder than you'd think. |
5ea55e0
to
f8fc86a
Compare
I just realized there are some mistakes... |
This shouldn't be a problem. Adaptive icons are supported since api 26 (8.0) while our min sdk is currently api 24 (7.0) so this shouldn't really matter. Thanks for the quick changes; I'll do a review once you got it fixed and I have a bit of time. |
Signed-off-by: provokateurin <[email protected]>
f8fc86a
to
65a8feb
Compare
I agree. I think everywhere else we also show the icon in blue with transparent background, so there we don't need the gradient either.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Closes #447
This was quite some work to get done, but I think it looks way better now:
It was not possible to split this into multiple commits as everything is coupled tightly.