Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(neon_http_client): split into separate interceptor client package #2467

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

Leptopoda
Copy link
Member

Signed-off-by: Nikolas Rimikis [email protected]

@Leptopoda Leptopoda force-pushed the refactor/nextcloud_test/use_fixture_interceptor branch from eff600e to 9be4363 Compare September 6, 2024 08:37
@Leptopoda Leptopoda enabled auto-merge September 6, 2024 08:37
@Leptopoda Leptopoda force-pushed the refactor/nextcloud_test/use_fixture_interceptor branch from 9be4363 to 47b3d61 Compare September 9, 2024 12:50
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.95%. Comparing base (87a7a39) to head (47b3d61).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...r_http_client/lib/src/interceptor_http_client.dart 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2467      +/-   ##
==========================================
+ Coverage   29.92%   29.95%   +0.02%     
==========================================
  Files         332      334       +2     
  Lines      124408   124453      +45     
==========================================
+ Hits        37225    37274      +49     
+ Misses      87183    87179       -4     
Flag Coverage Δ *Carryforward flag
account_repository 99.64% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from 87a7a39
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø) Carriedforward from 87a7a39
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from 87a7a39
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 87a7a39
interceptor_http_client 97.18% <94.11%> (?)
neon_dashboard 96.05% <ø> (ø) Carriedforward from 87a7a39
neon_framework 43.57% <ø> (ø)
neon_http_client 96.69% <100.00%> (+3.49%) ⬆️
neon_notifications 100.00% <ø> (ø) Carriedforward from 87a7a39
neon_talk 99.45% <ø> (ø) Carriedforward from 87a7a39
nextcloud 25.90% <ø> (ø)
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 87a7a39
talk_app 99.09% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...lient/lib/src/interceptors/cookie_interceptor.dart 100.00% <ø> (ø)
...rceptors/authorization_throttling_interceptor.dart 100.00% <ø> (ø)
.../lib/src/interceptors/base_header_interceptor.dart 83.33% <ø> (ø)
..._client/lib/src/interceptors/csrf_interceptor.dart 97.14% <ø> (ø)
...ges/neon_http_client/lib/src/neon_http_client.dart 100.00% <100.00%> (+4.16%) ⬆️
...r_http_client/lib/src/interceptor_http_client.dart 94.11% <94.11%> (ø)

@Leptopoda Leptopoda merged commit 79bbbd2 into main Sep 9, 2024
10 checks passed
@Leptopoda Leptopoda deleted the refactor/nextcloud_test/use_fixture_interceptor branch September 9, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants