Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neon_lints): update lints #2526

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

Leptopoda
Copy link
Member

I disabled document_ignores for now as it would be too much effort to document all of them now.

Signed-off-by: Nikolas Rimikis <[email protected]>
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.52%. Comparing base (c81a183) to head (116219f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    dart-lang/linter#2526   +/-   ##
=======================================
  Coverage   28.52%   28.52%           
=======================================
  Files         355      355           
  Lines      136003   136003           
=======================================
  Hits        38794    38794           
  Misses      97209    97209           
Flag Coverage Δ *Carryforward flag
account_repository 98.76% <ø> (ø)
cookie_store 99.48% <ø> (ø)
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø)
dynamite_end_to_end_test 61.69% <ø> (ø)
dynamite_runtime 85.40% <ø> (ø)
interceptor_http_client 97.18% <ø> (ø)
neon_dashboard 96.05% <ø> (ø) Carriedforward from c81a183
neon_framework 59.27% <ø> (ø)
neon_http_client 97.50% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from c81a183
neon_talk 99.45% <ø> (ø) Carriedforward from c81a183
nextcloud 24.26% <ø> (ø)
notifications_app 97.40% <ø> (ø)
sort_box 90.90% <ø> (ø)
talk_app 98.94% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/cookie_store/lib/src/storable_cookie.dart 100.00% <ø> (ø)
packages/neon_framework/lib/src/bloc/result.dart 92.30% <ø> (ø)
..._framework/lib/src/settings/models/exportable.dart 90.90% <ø> (ø)
...neon_framework/lib/src/settings/models/option.dart 100.00% <ø> (ø)
...lib/src/settings/utils/settings_export_helper.dart 100.00% <ø> (ø)
packages/neon_framework/lib/src/theme/icons.dart 30.43% <ø> (ø)

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given https://github.com/dart-lang/linter/issues/5065, should the type references really be converted or just ignored for now?

packages/neon_lints/lint_maker.yaml Show resolved Hide resolved
@Leptopoda
Copy link
Member Author

Leptopoda commented Sep 29, 2024

Given dart-lang/sdk#59516, should the type references really be converted or just ignored for now?

I don't see this moving forward in the near future, so we'd need to disable the lint.I'm not so sure how much these docs are even useful, as the generated html will include a link to the type from the attributes that use it.

@Leptopoda Leptopoda merged commit 86de9d7 into main Sep 29, 2024
10 checks passed
@Leptopoda Leptopoda deleted the feat/neon_lints/update_lints branch September 29, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants