Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): publish packages #2575

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

provokateurin
Copy link
Member

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.67%. Comparing base (d68f74a) to head (c52acef).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2575   +/-   ##
=======================================
  Coverage   28.67%   28.67%           
=======================================
  Files         366      366           
  Lines      136299   136299           
=======================================
  Hits        39079    39079           
  Misses      97220    97220           
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø)
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø)
dynamite_end_to_end_test 61.69% <ø> (ø)
dynamite_runtime 85.40% <ø> (ø)
interceptor_http_client 97.18% <ø> (ø)
neon_dashboard 96.05% <ø> (ø) Carriedforward from d68f74a
neon_framework 59.20% <ø> (ø)
neon_http_client 97.50% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from d68f74a
neon_storage 94.66% <ø> (ø)
neon_talk 99.45% <ø> (ø) Carriedforward from d68f74a
nextcloud 24.26% <ø> (ø)
notifications_app 97.40% <ø> (ø)
notifications_push_repository 98.59% <ø> (ø)
sort_box 90.90% <ø> (ø)
talk_app 98.94% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to disagree with melos here, as this should be 8.0.2

@provokateurin
Copy link
Member Author

No it is correct due to #2546

@provokateurin provokateurin merged commit 2b95461 into main Oct 19, 2024
10 checks passed
@provokateurin provokateurin deleted the chore/release/publish-packages branch October 19, 2024 10:01
@Leptopoda
Copy link
Member

Then let me correct myself. I disagree with the commit type used back then as it's a tooling change and doesn't add any functionality to the released package.

@provokateurin
Copy link
Member Author

Yes, that's what I thought as well when I saw the bump. I'll be more careful next time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants