Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web support #372

Merged
merged 5 commits into from
Feb 18, 2024
Merged

Add web support #372

merged 5 commits into from
Feb 18, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Jun 9, 2023 •
edited
Loading

Closes #783

@provokateurin provokateurin force-pushed the feature/web branch 2 times, most recently from 0c5cb15 to f5c75e6 Compare June 10, 2023 15:57
This was referenced Jun 13, 2023
Merged
Merged
Merged
Merged
Merged
@provokateurin provokateurin force-pushed the feature/web branch 5 times, most recently from 584aa33 to 6a68939 Compare June 18, 2023 20:08
@provokateurin provokateurin force-pushed the feature/web branch 4 times, most recently from c72980c to ccdb170 Compare July 15, 2023 15:19
@provokateurin provokateurin force-pushed the feature/web branch 5 times, most recently from 41f0839 to 751f6e4 Compare August 5, 2023 10:12
@provokateurin provokateurin force-pushed the feature/web branch 2 times, most recently from 47d097e to fb3b9b0 Compare August 10, 2023 19:24
This was referenced Aug 25, 2023
Merged
Merged
@provokateurin provokateurin force-pushed the feature/web branch 3 times, most recently from 03bde58 to e19bc30 Compare August 31, 2023 08:32
Base automatically changed from feat/tool/check-dart-html-usage to main January 31, 2024 08:05
@provokateurin provokateurin force-pushed the feature/web branch 3 times, most recently from bfba720 to 08094db Compare February 6, 2024 20:24
@provokateurin provokateurin force-pushed the feature/web branch 2 times, most recently from d3c2de7 to d4163e0 Compare February 12, 2024 17:37
@provokateurin provokateurin mentioned this pull request Feb 14, 2024
Merged
@provokateurin provokateurin force-pushed the feature/web branch 2 times, most recently from 12b46c3 to 42428a6 Compare February 17, 2024 15:31
@provokateurin provokateurin mentioned this pull request Feb 17, 2024
Merged
@provokateurin provokateurin changed the base branch from main to refactor/neon_framework/platform-plugin February 17, 2024 16:18
@provokateurin provokateurin force-pushed the refactor/neon_framework/platform-plugin branch from 16abdc3 to 853f1db Compare February 17, 2024 16:21
Base automatically changed from refactor/neon_framework/platform-plugin to main February 17, 2024 19:21
Leptopoda
Leptopoda approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see where it goes 🎉
Please also adjust the find_dart_html check to reflect our usage of the web package.

neon/tool/find-dart-html-usage.sh

Lines 9 to 10 in 4ce893d

echo "Use package:universal_html/html.dart instead"
exit 1

@provokateurin provokateurin merged commit 2af17ea into main Feb 18, 2024
8 checks passed
@provokateurin provokateurin deleted the feature/web branch February 18, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leptopoda Leptopoda Leptopoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Web support
2 participants
@provokateurin @Leptopoda