Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch GenericFileException in Generate #488

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Catch GenericFileException in Generate #488

merged 1 commit into from
Jul 29, 2024

Conversation

nielstron
Copy link
Contributor

This fixes #487

@nielstron @st3iny
Catch GenericFileException in Generate
c08d74a 
Signed-off-by: Niels Mündler <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
st3iny approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I cleaned up the code a bit and added the same logic to the pre-generate command.

@st3iny st3iny enabled auto-merge July 29, 2024 07:27
@st3iny st3iny merged commit ca48f67 into nextcloud:main Jul 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

Assignees
No one assigned
Labels
4. to release enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preview:generate-all crashes at the same image repeatedly
2 participants
@nielstron @st3iny