Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip .nomedia when running pre-generate #508

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Sep 8, 2024

Fix #433

Also enable unit testing on CI again (hence the huge diff).

@st3iny st3iny self-assigned this Sep 8, 2024
@st3iny st3iny force-pushed the fix/nomedia-pre-generate branch from 580cab2 to e732ab7 Compare September 8, 2024 14:52
@st3iny st3iny force-pushed the fix/nomedia-pre-generate branch from e732ab7 to aec0c11 Compare September 8, 2024 14:53
@st3iny st3iny merged commit 472bbd6 into main Sep 8, 2024
14 checks passed
@st3iny st3iny deleted the fix/nomedia-pre-generate branch September 8, 2024 15:23
@st3iny
Copy link
Member Author

st3iny commented Sep 8, 2024

/backport to stable5.6

@th0rgall
Copy link

th0rgall commented Sep 9, 2024

Thank you @st3iny! I'm happy that I'll be able to switch on the automatic preview generation now 🙂

Do the above backport messages mean that this fix is already available in the update packages of 5.6.0? I'm still on NC 28, which has 5.6.0 listed as its stable channel. I'll update my NC soon.

@st3iny
Copy link
Member Author

st3iny commented Sep 9, 2024

I'm planning to do a v5.6.1 release soonish which will include the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preview:pre-generate ignores .nomedia in ancestor folders of the added/modified folder
2 participants