Skip to content

Commit

Permalink
fix(dav): default calendar and address book not created on first login
Browse files Browse the repository at this point in the history
Signed-off-by: Richard Steinmetz <[email protected]>
  • Loading branch information
st3iny committed Jan 23, 2025
1 parent 346253e commit 8fb04cd
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion apps/dav/lib/AppInfo/Application.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
use OCP\Config\BeforePreferenceSetEvent;
use OCP\Contacts\IManager as IContactsManager;
use OCP\DB\Events\AddMissingIndicesEvent;
use OCP\EventDispatcher\GenericEvent;
use OCP\EventDispatcher\IEventDispatcher;
use OCP\Federation\Events\TrustedServerRemovedEvent;
use OCP\Files\AppData\IAppDataFactory;
Expand All @@ -90,7 +91,6 @@
use OCP\User\Events\OutOfOfficeScheduledEvent;
use Psr\Container\ContainerInterface;
use Psr\Log\LoggerInterface;
use Symfony\Component\EventDispatcher\GenericEvent;
use Throwable;
use function is_null;

Expand Down
5 changes: 5 additions & 0 deletions build/integration/dav_features/caldav.feature
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,8 @@ Feature: caldav
When "user0" requests principal "users/user0" on the endpoint "/remote.php/dav/principals/"
Then The CalDAV response should be multi status
And The CalDAV response should contain a property "{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL" with a href value "/remote.php/dav/calendars/user0/MyCalendar2/"

Scenario: Should create default calendar on first login
Given user "first-login" exists
When "first-login" requests calendar "first-login/personal" on the endpoint "/remote.php/dav/calendars/"
Then The CalDAV HTTP status code should be "207"
4 changes: 4 additions & 0 deletions build/integration/dav_features/carddav.feature
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,7 @@ Feature: carddav
When "user0" sends a create addressbook request to "admin/MyAddressbook2" on the endpoint "/remote.php/dav/addressbooks/"
Then The CardDAV HTTP status code should be "404"
And The CardDAV exception is "Internal Server Error"

Scenario: Should create default addressbook on first login
Given user "first-login" exists
Then "first-login" requests addressbook "first-login/contacts" with statuscode "207" on the endpoint "/remote.php/dav/addressbooks/users/"

0 comments on commit 8fb04cd

Please sign in to comment.