-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(user status): automate user status for events #40615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
fca0790
to
f4cfa4d
Compare
8e8911b
to
d307b47
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Having nextcloud/calendar#3193 would be good @ChristophWurst - shall I add it as a followup? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Would it not be possible to just change the icons for all the statuses? |
Agree with @nimishavijay. If that is out of scope, a good first step would be to just do the same that we do when in a call – which is not changing the status, only emoji and status text, right @nickvergessen? |
We do change the status to "Away" (when the user was not invisible (=> no status change) or DND (=> in call with DND)) |
Aight, chaningin the status to "away" for now, and removing the icons. Follow up ticket for icon changes discussion here:#41299 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked for my local instance once I cleared the Away override and the custom status message
23fbe23
to
ab261fc
Compare
e358b7b
to
1661393
Compare
1661393
to
fc9f805
Compare
and automatically set a user status to free or busy depending on their calendar transparency, event status and availability settings Signed-off-by: Anna Larch <[email protected]>
fc9f805
to
f14a4f8
Compare
Failing Cypress test: theming/admin-settings.cy.ts (unrelated) |
Summary
The user status currently only takes into account the availability settings. Automatically set a user status to free or busy depending on their calendar transparency, event status and availability settings combined.
This can be done with a free/busy request just like the Calendar app does for the free/busy modal.
How to test:
THe easiest way to test is to create 5- minute calendar events and have some sort of VAVAILABLITY setting.
The decision tree is the following:
Status decision tree:
USER DEFINED STATUS
NOT USER DEFINED
TODO
Checklist
Screenshots before/after for front-end changesBackports requested where applicable (ex: critical bugfixes)