fix: Allow to set app order on navigation entries added by closures #41341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
susnux
force-pushed
the
fix/apporder-on-closures
branch
2 times, most recently
from
e9c5ec2 to
ed87cd0
Compare
susnux
force-pushed
the
fix/apporder-on-closures
branch
2 times, most recently
from
64d17da to
b14a7c4
Compare
juliusknorr
approved these changes
Nov 8, 2023
susnux
force-pushed
the
fix/apporder-on-closures
branch
from
b14a7c4 to
492344e
Compare
come-nc
reviewed
Nov 9, 2023
Merged
susnux
force-pushed
the
fix/apporder-on-closures
branch
from
492344e to
9ebd467
Compare
come-nc
approved these changes
Nov 9, 2023
come-nc
requested changes
Nov 9, 2023
come-nc
reviewed
Nov 9, 2023
susnux
force-pushed
the
fix/apporder-on-closures
branch
from
aa45d93 to
cada718
Compare
come-nc
approved these changes
Nov 9, 2023
Merged
susnux
force-pushed
the
fix/apporder-on-closures
branch
from
cada718 to
b3da564
Compare
|
/compile / |
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
…tries added as closures Signed-off-by: Ferdinand Thiessen <[email protected]>
…sures to NavigationManager Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
… the navigation entries Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/apporder-on-closures
branch
from
b3da564 to
927e7fc
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some apps, e.g. talk, use the navigation manager to inject the navigation entry instead of using the appinfo.xml
This caused issues as the app property was not set.
This moves some logic from init of the NavigationManager to the add function and refactors the app order config to use navigation IDs rather than app names + index of navigation from appinfo.xml
Also adjusted frontend code for that change.
Checklist