-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lexicon): configurable default value #49848
Merged
ArtificialOwl
merged 2 commits into
master
from
feat/noid/lexicon-configurable-default-value
Jan 14, 2025
Merged
feat(lexicon): configurable default value #49848
ArtificialOwl
merged 2 commits into
master
from
feat/noid/lexicon-configurable-default-value
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ArtificialOwl
force-pushed
the
feat/noid/lexicon-configurable-default-value
branch
6 times, most recently
from
December 17, 2024 10:47
24e95fc
to
422dcb2
Compare
ArtificialOwl
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Dec 17, 2024
Merged
come-nc
reviewed
Jan 9, 2025
ArtificialOwl
force-pushed
the
feat/noid/lexicon-configurable-default-value
branch
from
January 9, 2025 10:43
422dcb2
to
824f954
Compare
come-nc
requested changes
Jan 9, 2025
ArtificialOwl
force-pushed
the
feat/noid/lexicon-configurable-default-value
branch
from
January 9, 2025 13:39
824f954
to
e65fb5c
Compare
come-nc
approved these changes
Jan 13, 2025
sorbaugh
approved these changes
Jan 13, 2025
Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
force-pushed
the
feat/noid/lexicon-configurable-default-value
branch
from
January 14, 2025 11:38
4296647
to
28acc00
Compare
Merged
ArtificialOwl
deleted the
feat/noid/lexicon-configurable-default-value
branch
January 14, 2025 16:12
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature require that the config key is listed in the Config Lexicon.
'lexicon.default.userconfig'
that overwrite default userconfig value:'lexicon.default.userconfig.enforced'
that lock config value to default:(enforced default value will be chosen from the one stored in
config.php
, the one set in the lexicon then to the one from the code)CoreConfigLexicon
for'core'
config keysalso some improvement in the resource management