fix(files): allow triggering a Files reload directly #50354
Conversation
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
requested review from
nfebe and
szaimen
and removed request for
a team
There was a problem hiding this comment.
Currently not sure about that.
Maybe we even need somekind of auto-reload in the files app, e.g. if there are too many updates then we do a background fetch to sync.
Also maybe do it regular in the background to get new files created by other tabs / sync clients (every minute if the user is not AFK.
| if (!window?.OCP?.Files?.App) { | ||
| window.OCP.Files.App = {} | ||
| } | ||
| Object.assign(window.OCP.Files.App, { ...window.OCP.Files.App, reload: this.fetchContent }) |
There was a problem hiding this comment.
I think we should not add anything new to window.OCP, this should die IMHO.
What is the general use case? Files got converted? Can we not just emit afiles:node:created?
Because we currently already have events for node deletion / creation / update, so everything in the current directory could be modified and changing the directory will cause a reload anyways.
But if we need a reload mechanism, why not provide a reload method in the file router, could fit there. OCP.Files.Router.reload() or maybe just an event files:reload.
There was a problem hiding this comment.
What is the general use case? Files got converted? Can we not just emit a
files:node:created? Because we currently already have events for node deletion / creation / update, so everything in the current directory could be modified and changing the directory will cause a reload anyways.
That would be the smartest approach. But could be overly complicated.
Thanks for reminding me to not take shortcuts, I'll do the following:
- if the current folder matches one of the converted files
- then we fetch each files
- and we trigger a
files:node:created
There was a problem hiding this comment.
Exactly what I needed for feedback @susnux ! ❤️ 🤗
Should simplify how we interact.
Sometimes it make sense to also just trigger a full reload directly 🤷
@susnux, thoughts?
I'm not 100% sire this makes sense 🤔
OCP.Files.Appnextcloud-libraries/nextcloud-typings#277