Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): default calendar and address book not created on first login #50369

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jan 23, 2025

  • Resolves: none

Summary

Required for nextcloud/calendar#6648

The first login hook was not triggered because the event was not checked against the correct class via instanceof.

Consider the following code snippet further down:

// first time login event setup
$dispatcher->addListener(IUser::class . '::firstLogin', function ($event) use ($hm): void {
if ($event instanceof GenericEvent) {
$hm->firstLogin($event->getSubject());
}
});

Checklist

@st3iny st3iny self-assigned this Jan 23, 2025
@st3iny st3iny added bug 3. to review Waiting for reviews regression feature: caldav Related to CalDAV internals feature: carddav Related to CardDAV internals labels Jan 23, 2025
@st3iny st3iny modified the milestones: Nextcloud 31, Nextcloud 32 Jan 23, 2025
@st3iny
Copy link
Member Author

st3iny commented Jan 23, 2025

/backport to stable31

@st3iny
Copy link
Member Author

st3iny commented Jan 23, 2025

/backport to stable30

@st3iny
Copy link
Member Author

st3iny commented Jan 23, 2025

/backport to stable29

Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@st3iny

This comment was marked as resolved.

@st3iny st3iny force-pushed the fix/dav/first-login-listener branch from a2c59d2 to d3126cd Compare January 23, 2025 21:04
@st3iny st3iny enabled auto-merge January 23, 2025 21:04
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 23, 2025
@st3iny st3iny merged commit e54c078 into master Jan 23, 2025
190 checks passed
@st3iny st3iny deleted the fix/dav/first-login-listener branch January 23, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: caldav Related to CalDAV internals feature: carddav Related to CardDAV internals regression
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

3 participants