Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove reference to ILogger #1937

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Sep 25, 2024

Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge requested a review from come-nc September 25, 2024 15:17
@artonge artonge self-assigned this Sep 25, 2024
@artonge artonge added 3. to review technical debt php Pull requests that update Php code labels Sep 25, 2024
Copy link

cypress bot commented Sep 25, 2024

Social    Run #968

Run Properties:  status check errored Errored #968  •  git commit dd9d0255cb: chore: Remove reference to ILogger
Project Social
Branch Review artonge/chore/remove_ilogger
Run status status check errored Errored #968
Run duration 01m 11s
Commit git commit dd9d0255cb: chore: Remove reference to ILogger
Committer Louis
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 0
View all changes introduced in this branch ↗︎

@artonge
Copy link
Contributor Author

artonge commented Sep 26, 2024

@ArtificialOwl can you force merge? cypress will never get green

@ArtificialOwl ArtificialOwl merged commit 364ce95 into master Sep 26, 2024
40 of 43 checks passed
@ArtificialOwl ArtificialOwl deleted the artonge/chore/remove_ilogger branch September 26, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review php Pull requests that update Php code technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILogger is deprecated and will be removed
3 participants