Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename message expiration title #3414

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Rename message expiration title #3414

merged 1 commit into from
Oct 27, 2023

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Oct 27, 2023 •
edited
Loading

🖼️ Screenshots

🏚️ Before 🏡 After
grafik grafik

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi added the 3. to review Waiting for reviews label Oct 27, 2023
@mahibi mahibi added this to the 18.0.0 milestone Oct 27, 2023
@mahibi mahibi self-assigned this Oct 27, 2023
@mahibi mahibi requested a review from rapterjet2004 October 27, 2023 15:49
@mahibi mahibi enabled auto-merge October 27, 2023 15:50
@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8989
Errors00

SpotBugs

CategoryBaseNew
Bad practice1818
Correctness1010
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total169169

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3414-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 074e2c6 into master Oct 27, 2023
15 of 16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/renameMessageExpirationTitle branch October 27, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rapterjet2004 rapterjet2004 rapterjet2004 approved these changes

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
18.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mahibi @rapterjet2004