Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use of parameterized constructor with fragments #3677

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

parneet-guraya
Copy link
Contributor

Fixes: #3676

FilterConversationFragment

document_6271528266574596872.mp4

DateTimePickerFragment

document_6271528266574596873.mp4

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@parneet-guraya parneet-guraya added the 3. to review Waiting for reviews label Feb 29, 2024
@parneet-guraya
Copy link
Contributor Author

TODO: The DateTimePickerFragment doesn't handle state during config changes. Will create another issue and solve it there.

@parneet-guraya parneet-guraya force-pushed the use-default-constructor branch from 711192b to 07137be Compare February 29, 2024 19:19
@AndyScherzinger AndyScherzinger requested review from sowjanyakch and removed request for AndyScherzinger February 29, 2024 19:21
@parneet-guraya parneet-guraya force-pushed the use-default-constructor branch from 07137be to f55e61b Compare March 5, 2024 02:41
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Codacy

Lint

TypemasterPR
Warnings8181
Errors1010

SpotBugs

CategoryBaseNew
Bad practice66
Correctness99
Dodgy code111111
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total139139

Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
@mahibi mahibi force-pushed the use-default-constructor branch from f55e61b to 3866bee Compare March 11, 2024 14:35
@mahibi mahibi added this to the 19.0.0 milestone Mar 11, 2024
@mahibi mahibi merged commit 36e0c13 into master Mar 11, 2024
11 of 16 checks passed
@mahibi mahibi deleted the use-default-constructor branch March 11, 2024 14:35
@mahibi
Copy link
Collaborator

mahibi commented Mar 11, 2024

👍

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3677-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default constructor must be used with fragments
2 participants