Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide some features if federation is not available #3698

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Mar 7, 2024

hide some features that are not available (yet) for federation.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi added the 3. to review Waiting for reviews label Mar 7, 2024
@mahibi mahibi added this to the 19.0.0 milestone Mar 7, 2024
@mahibi mahibi self-assigned this Mar 7, 2024
+ add capability queries (not yet used)

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi force-pushed the feature/noid/handleFederationFeaturesByCapabilities branch from 1eb4c29 to 625de65 Compare March 12, 2024 09:53
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8181
Errors1010

SpotBugs

CategoryBaseNew
Bad practice66
Correctness99
Dodgy code112112
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total140140

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3698-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

@sowjanyakch sowjanyakch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mahibi mahibi merged commit 3832e84 into master Mar 12, 2024
15 of 16 checks passed
@mahibi mahibi deleted the feature/noid/handleFederationFeaturesByCapabilities branch March 12, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants