Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented delete-messages-unlimited feature #3707

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

sowjanyakch
Copy link
Contributor

Resolves #3614.

If the "delete-messages-unlimited" capability is available, deleting messages without any time restriction is possible; otherwise, the time limit for deleting messages is six hours.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch self-assigned this Mar 13, 2024
@sowjanyakch sowjanyakch added this to the 19.0.0 milestone Mar 13, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Mar 13, 2024
@mahibi mahibi force-pushed the support-delete-messages-unlimited-capability branch from a91ce53 to d802009 Compare March 19, 2024 12:31
@mahibi mahibi merged commit a4a04eb into master Mar 19, 2024
14 of 16 checks passed
@mahibi mahibi deleted the support-delete-messages-unlimited-capability branch March 19, 2024 12:31
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8181
Errors1010

SpotBugs

CategoryBaseNew
Bad practice66
Correctness99
Dodgy code112112
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total140140

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3707-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement delete-messages-unlimited feature
2 participants