Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain Settings Screen Scroll State #3720

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

parneet-guraya
Copy link
Contributor

🖼️ Screenshots

Before

Record_2024-03-17-03-45-22.mp4

After

Record_2024-03-17-03-53-02.mp4

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@parneet-guraya parneet-guraya requested a review from mahibi March 16, 2024 22:32
@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Mar 17, 2024
@parneet-guraya parneet-guraya force-pushed the settings-screen-scroll-state branch from 14bba17 to a337deb Compare March 17, 2024 23:34
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8181
Errors1010

SpotBugs

CategoryBaseNew
Bad practice66
Correctness99
Dodgy code112112
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total140140

Signed-off-by: parneet-guraya <[email protected]>
@mahibi mahibi force-pushed the settings-screen-scroll-state branch from a337deb to 1dce0ca Compare March 19, 2024 12:42
@mahibi mahibi merged commit 325da27 into master Mar 19, 2024
13 of 15 checks passed
@mahibi mahibi deleted the settings-screen-scroll-state branch March 19, 2024 12:43
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3720-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@AndyScherzinger AndyScherzinger added this to the 19.0.0 milestone Mar 19, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants