Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually bump to 19.0.0 Alpha 02 #3733

Merged
merged 1 commit into from
Mar 19, 2024
Merged

manually bump to 19.0.0 Alpha 02 #3733

merged 1 commit into from
Mar 19, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Mar 19, 2024

there seems to be something wrong that alpha workflow did not update the apps version. Thats why gplay complains with
"Google Api Error: forbidden: Cannot update a published APK. - Cannot update a published APK." because it always tries to upload 19.0.0 Alpha 02.

On nextcloud ftp server, it was most probably always overwritten as there is an up to date alpha2 version.

Seeting the version number to 19.0.0 Alpha 02 should make sure that an alpha 3 is built on next automation run.

The root cause that the version was/is not changed by the automation is still unclear.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

there seems to be something wrong that alpha workflow did not update the apps version.
Thats why gplay complains with
"Google Api Error: forbidden: Cannot update a published APK. - Cannot update a published APK."
because it always tries to upload 19.0.0 Alpha 02.

On nextcloud ftp server, it was most probably always overwritten as there is an up to date alpha2 version.

Seeting the version number to 19.0.0 Alpha 02 should make sure that an alpha 3 is built on next automation run.

The root cause that the version was/is not changed by the automation is still unclear.

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi self-assigned this Mar 19, 2024
@mahibi mahibi merged commit 3da5c2a into master Mar 19, 2024
14 of 16 checks passed
@mahibi mahibi deleted the fix19Alpha02Build branch March 19, 2024 13:15
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8181
Errors1010

SpotBugs

CategoryBaseNew
Bad practice66
Correctness99
Dodgy code112112
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total140140

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3733-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi
Copy link
Collaborator Author

mahibi commented Mar 19, 2024

manual trigger of alpha automation unveiled that push fails because of "Commits must have verified signatures":

[master a895264f8] Weekly 19.0.0 Alpha 03
 1 file changed, 2 insertions(+), 2 deletions(-)
+ git fetch
+ git rebase --onto origin/master
First, rewinding head to replay your work on top of it...
Applying: Weekly 19.0.0 Alpha 03
+ git push
Counting objects: 4, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 395 bytes | 395.00 KiB/s, done.
Total 4 (delta 3), reused 0 (delta 0)
remote: Resolving deltas: 100% (3/3), completed with 3 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: Commits must have verified signatures. Changes must be made through a pull request. Required status check "continuous-integration/drone/pr" is expected.
To github.com:nextcloud/talk-android.git
 ! [remote rejected]     master -> master (protected branch hook declined)
error: failed to push some refs to '[email protected]:nextcloud/talk-android.git'
+ git tag alpha-190000003
+ git push origin alpha-190000003

So Alpha3 is published on gplay and ftp, but problem with verified signatures / push has to be solved for next run.
Manually bumped version to alpha3 for now.

mahibi added a commit that referenced this pull request Mar 19, 2024
manual bump because alpha automation failed to bump version because of
"Commits must have verified signatures".
See #3733 (comment)

Signed-off-by: Marcel Hibbe <[email protected]>
mahibi added a commit that referenced this pull request Apr 5, 2024
still because of #3733

Signed-off-by: Marcel Hibbe <[email protected]>
mahibi added a commit that referenced this pull request Apr 15, 2024
still because of #3733

Signed-off-by: Marcel Hibbe <[email protected]>
mahibi added a commit that referenced this pull request Apr 15, 2024
still because of #3733

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
Copy link
Collaborator Author

mahibi commented Sep 15, 2024

reason was that the bot had not enough permissions for the repository to push directly to master.
Role of the bot was set to admin which fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant