-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use DialogFragment for Phone Number Integration #3738
Conversation
fde02ba
to
ed9e69e
Compare
Good question from @parneet-guraya copied from public chat: "Hi π . In some places we are using AlertDialog Builder to show a dialog instead of a DialogFragment. As a result neither they retain state nor they survive configuration changes. I was wondering if we should convert those to use DialogFragment as well? |
I am still undecided. Maybe this behavior could be fixed when switching to more modern solutions like Jetpack Compose etc.? |
I think we should atleast use DialogFragment for Dialogs those have some state. Otherwise it is bad experience for the user if the dialog loose state for eg. Dialogs with Text fields like this one. It should retain whatever user has typed in. let me know your thoughts :-) |
@parneet-guraya I agree that it is a bad user experience. If there are many AlertDialogs, I prefer to use Jetpack Compose. In Jetpack Compose, we can reuse the composable with custom styles and content. Managing state also becomes easier. The approach you are mentioning creates many xml layouts. These files will be anyways converted to Jetpack Compose eventually. |
Signed-off-by: Parneet Singh <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]> Signed-off-by: Marcel Hibbe <[email protected]>
Lets merge this one as it definitely improves the dialog. |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3738-talk.apk |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Fixes: #3737
πΌοΈ Screenshots
Record_2024-03-20-22-05-33.mp4
π Checklist
/backport to stable-xx.x