Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message delay on send and delete #3746

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Mar 21, 2024

🚧 TODO

  • fix message send delay
  • Fix message delete delay
  • Fix xml layout error on smaller screens

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Mar 21, 2024
@rapterjet2004 rapterjet2004 changed the title Fix message delay on send Fix message delay on send and delete Mar 22, 2024
@rapterjet2004 rapterjet2004 marked this pull request as ready for review March 26, 2024 13:03
@rapterjet2004 rapterjet2004 force-pushed the issue-3744-sent-message-delayed branch from 3e0714a to 1305f65 Compare March 26, 2024 13:23
@rapterjet2004 rapterjet2004 requested a review from mahibi March 26, 2024 13:27
@rapterjet2004 rapterjet2004 force-pushed the issue-3744-sent-message-delayed branch 2 times, most recently from 4d8c79e to a34a28a Compare March 29, 2024 13:16
@rapterjet2004
Copy link
Contributor Author

/backport to stable-19.0

Signed-off-by: Julius Linus <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi force-pushed the issue-3744-sent-message-delayed branch from a34a28a to 07bf654 Compare April 3, 2024 14:41
Copy link
Contributor

github-actions bot commented Apr 3, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3746-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 7e3d48f into master Apr 3, 2024
17 of 18 checks passed
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Codacy

Lint

TypemasterPR
Warnings8181
Errors1010

SpotBugs

CategoryBaseNew
Bad practice66
Correctness88
Dodgy code110110
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total137137

@mahibi mahibi deleted the issue-3744-sent-message-delayed branch April 3, 2024 14:50
@mahibi mahibi added this to the 19.1.0 milestone Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sent message not shown immediately
3 participants